search

cult-of-coders / grapher-react

Provides easy to use React Components that are suitable for grapher package.
https://atmospherejs.com/cultofcoders/grapher-react
39 stars 19 forks source link

Hard dependency on react-meteor-data #43

Open davidsavoie1 opened 4 years ago

davidsavoie1 commented 4 years ago

I'm trying to update react-meteor-data to the latest 2.0.1 version, but it seems that grapher-react has a dependency on an old version (0.2.16) that prevents such an update. Is it possible to lift this limitation? Thanks!

justbill2020 commented 4 years ago

same... not sure what i get updating to react-meteor-data v2.0.1 but i hate seeing those messages when i update meteor 👍

Isarstyle commented 4 years ago

It looks as if something went wrong on the upload to atmospherejs.com, getting the same issues, even if the github looks fine. Can you take a look into it?

`=> Errors prevented startup:

While selecting package versions: error: Conflict: Constraint react-meteor-data@0.2.15 is not satisfied by react-meteor-data 2.0.1. Constraints on package "react-meteor-data":

EDIT: got it to work by manually cloning the repo into my project folder. https://forums.meteor.com/t/how-to-install-meteor-package-direct-from-github/1693/2

Giribaldi commented 4 years ago

EDIT: got it to work by manually cloning the repo into my project folder. https://forums.meteor.com/t/how-to-install-meteor-package-direct-from-github/1693/2

I'm still having the issue, I can't find the packages folder, where did you clone it ? did you also add the packages after cloning it ?

Isarstyle commented 4 years ago

@Giribaldi there are two steps to get it working.

  1. you add cultofcoders:grapher-react to the meteor packages file
  2. then you clone the grapher-react repository in a packages folder next to the .meteor e.g. PROJECT/packages/grapher-react Then start meteor and it should work, have a great day!
heticeric commented 3 years ago

Hi @theodorDiaconu

Would you mind releasing the update to atmosphere, please ?

theodorDiaconu commented 3 years ago

@heticeric have you guys tried doing something like: "react-meteor-data@=2.0.1". Otherwise @heticeric create a PR for this 👍

erixtekila commented 3 years ago

Do that mean that this lib is not maintained anymore ? Thanks for your kind response.

theodorDiaconu commented 3 years ago

Ofcourse it is. But for bugs and critical things. Community should aid maintaining this.

On Thu, Dec 10, 2020 at 10:19 AM Eric Priou notifications@github.com wrote:

Do that mean that this lib is not maintained anymore ? Thanks for your kind response.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cult-of-coders/grapher-react/issues/43#issuecomment-742360939, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN3CT6MLNBDCOQXYEPZR4TSUB77HANCNFSM4KDKCWNA .

erixtekila commented 3 years ago

Otherwise create a PR for this 👍

Why would one create a PR on code that is actually running in this repo ? We only ask your team to publish the last commit to atmosphere registry.

Community should aid maintaining this.

Here is the place for PR, indeed ;)

webface commented 3 years ago

I too am having this bug and cant develop. Is there an official fix?

justbill2020 commented 3 years ago

@theodorDiaconu this is still an issue... nothing solves the issue. the latest commit just isn't published to meteor atmosphere... even after over a year. is this repo no longer maintained and should we all move away from grapher?

LordA98 commented 3 years ago

Any update on this?

Adding grapher-react to packages/ fixes it locally but this solution doesn't resolve issue in my CICD pipeline. Using @=2.1.2 does not work either.

theodorDiaconu commented 3 years ago

@LordA98 aren't there other breaking changes involved? Can you submit a PR?

erixtekila commented 3 years ago

Please @theodorDiaconu re-read https://github.com/cult-of-coders/grapher-react/issues/43#issuecomment-743183042 Lots of people claims you or your team to publish a fresh copy to atmosphere registry.

theodorDiaconu commented 3 years ago

Password: => Errors while initializing project:

While selecting package versions: error: Conflict: Constraint @.*** is not satisfied by peerlibrary:subscription-scope 0.1.0. Constraints on package "peerlibrary:subscription-scope":

It seems that there's more to the story.

On Tue, May 18, 2021 at 12:19 PM Eric Priou @.***> wrote:

Please @theodorDiaconu https://github.com/theodorDiaconu re-read #43 (comment) https://github.com/cult-of-coders/grapher-react/issues/43#issuecomment-743183042 Lots of people claims you or your team to publish a fresh copy to atmosphere registry.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cult-of-coders/grapher-react/issues/43#issuecomment-843005475, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN3CT3WIJPGUMRWHJ5YBFDTOIWKRANCNFSM4KDKCWNA .

erixtekila commented 3 years ago

An option to get rid of all this, is to use hooks instead of withTracker HOC. See this closed issue #41 for an implementation.

Greetings.