search

cult-of-coders / grapher-react

Provides easy to use React Components that are suitable for grapher package.
https://atmospherejs.com/cultofcoders/grapher-react
38 stars 19 forks source link

Using Reactive: False Returns Warning about componentWillReceiveProps Rename #46

Open LordA98 opened 4 years ago

LordA98 commented 4 years ago

Hi,

I've created a simple query to fetch data from the database. I have just changed it to 'reactive: false' and received this warning:

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: StaticQuery(GrapherQuery(SettingsForm))

This is my query:

export default withQuery(() => {
  return userInfo.clone()
}, {reactive: false, single: true})(SettingsForm)

Should I still be using a HOC if I reactivity is false? Or should I be fetching data from the database within a useEffect?

I am using Meteor@1.11.1 with React@16.3.1 and Grapher@1.3.19 / GrapherReact@0.1.5+.