search

cult-of-coders / grapher

Grapher: Meteor Collection Joins + Reactive GraphQL like queries
https://atmospherejs.com/cultofcoders/grapher
MIT License
275 stars 53 forks source link

Fix reactive counters when filtering on dates #402

Closed vparpoil closed 1 year ago

vparpoil commented 4 years ago

One test is failing for Reactive counts on named queries with date filtering (non reactive counts all work as expected). I couldn't find a fix for now, don't hesitate to give me some guidance on where to look for :) Thanks

See issue https://github.com/cult-of-coders/grapher/issues/401

vparpoil commented 4 years ago

I found the reason for this. The request is stringified here . Hence, the date object is transformed into a string and the mongo query fails to compare the string with dates. Here is a proposition to fix this behavior using meteor/ejson instead of json

StorytellerCZ commented 2 years ago

@vparpoil can you please merge the latest master and resolve the conflicts?

vparpoil commented 2 years ago

@StorytellerCZ I updated and resolved conflicts, thank you !

StorytellerCZ commented 1 year ago

Will be published in v1.4.1. Thank you @vparpoil!