Apply collection transforms after aggregations

cult-of-coders / grapher

Grapher: Meteor Collection Joins + Reactive GraphQL like queries

https://atmospherejs.com/cultofcoders/grapher

MIT License

275 stars 53 forks source link

Apply collection transforms after aggregations #421

Closed Floriferous closed 4 years ago

Floriferous commented 4 years ago

Closes #420

This applies a collection transform right after aggregations

bhunjadi commented 4 years ago

I've taken similar approach with #400 where aggregate for virtual links is replaced with find. There's no need to handle these from within grapher in that case.

There's also discussion in #387 about aggregate vs find.

Floriferous commented 4 years ago

Yeah, that'd be great, this PR is a bit hacky anyways. Let's hope we can get these merged.

Floriferous commented 4 years ago

Maybe you can port over my tests however.

bhunjadi commented 4 years ago

Yes, I did not test the effects of transform there. I'll update the PR with your tests.