updated package.js, updated packages, fixed broken tests

cult-of-coders / grapher

Grapher: Meteor Collection Joins + Reactive GraphQL like queries

https://atmospherejs.com/cultofcoders/grapher

MIT License

275 stars 53 forks source link

updated package.js, updated packages, fixed broken tests #457

Closed donstephan closed 2 years ago

donstephan commented 2 years ago

updated denormalize package
note that sift was quite a few versions back
all tests are passing

theodorDiaconu commented 2 years ago

looks good, the previous problems I had were related to meteor publish. Can you try a publication of your fork to see it works ok, other than that thank you.

donstephan commented 2 years ago

It gets through all the pre-publish functions well (which I believe makes it past the interdependency checks). The versionsfrom should handle the version constraints issue that was being had since that now syncs with matb33:collection-hooks. herteby:denormalize@0.6.6 has been updated to use the latest version of that package as well. Happy to actually publish a package if you think it's necessary though.

paulincai commented 2 years ago

Hi @theodorDiaconu. Is this ok to get a merge?

donstephan commented 2 years ago

Following up on this. Need anything else on my end?

donstephan commented 2 years ago

@StorytellerCZ can this be merged? Fixes issues with 2.3+.

StorytellerCZ commented 2 years ago

@donstephan yes, thank you! I will test now and release if test pass.

donstephan commented 2 years ago

thanks!

StorytellerCZ commented 2 years ago

@donstephan had to revert the use of Object.fromEntries in tests. Can you please take a look on that? https://app.travis-ci.com/github/StorytellerCZ/grapher/builds/246870089

StorytellerCZ commented 2 years ago

See #461

donstephan commented 2 years ago

Looks good, not sure why I had to change that to be Object.fromEntries for tests to pass locally. I suspect I was using a different driver. Thanks for setting up Jenkins again. I'll test the release in a few hours here.

StorytellerCZ commented 2 years ago

Great, let me know if everything is working fine. I haven't had an opportunity to test things beyond automated tests, so any feedback is welcomed.