Closed tylerbarnum closed 6 months ago
For @alexcritschristoph, change pip install -r requirements
to pip install -r requirements.txt
in the instructions above. Technically also for @tylerbarnum, but want to make sure Alex sees.
Needs a .gitignore
. A suitable one is here: https://gist.github.com/knightjdr/dc89bd33a4b21546c15822034871580b.
Issues:
test.predictions.tsv.predictions.tsv
.test.predictions.tsv
to .gitignore
@knightjdr Any strong feelings on bumping the python version closer to current? I'm on 3.8 because a package that I no longer use required it
@knightjdr Any strong feelings on bumping the python version closer to current? I'm on 3.8 because a package that I no longer use required it
I would specify it at >= 3.8
. Not everyone will be using a newer version, so it's good to provide some flexibility here. Compatibility with newer versions shouldn't be an issue.
Adding these from Alex to "yet to come" (next PR):
This PR enables the use of the models to predict growth conditions for bacteria and archaea. It does not yet allow the user to reproduce the development or evaluation of the models.
To quickly test: you should be able to run this and have a result printed and a file
test.predictions.tsv
produced:As noted in the README, you can also check out the notebook
notebooks/tutorial.ipynb
to see how individual functions work. This could be a helpful way you and users to understand the code before diving into the codebase. In particular the code to compute traits from BacDive download will make a lot more sense when you see that the data is a wacky nested dictionary.Yet to come:
Other considerations:
joblib
.dev
, and we can merge into main once unit tests, etc. are done.