cultureamp / cfparams

Wrangle parameters for AWS CloudFormation
MIT License
0 stars 0 forks source link

Allow to use empty string as a valid value #8

Closed dnagir closed 6 years ago

dnagir commented 6 years ago

Currently it appears that cfparams does not allow empty values to be passed as parameters.

Example:

# parameters file
BugsnagApiKey: "" # TODO: Ignore for development account
# partial tempalte file:
Parameters:
  BugsnagApiKey:
    Description: API Key for Bugsnag error reporting
    Type: String

Executed with the arguments:

  cfparams \
    --template cloudformation.yml \
    --parameters "$PARAMS_FILE" \
    --accept-defaults \
    --no-previous

The error:

An error occurred (ValidationError) when calling the CreateStack operation: ParameterValue for ParameterKey BugsnagApiKey is required

The produced output for that key:

  {
    "ParameterKey": "BugsnagApiKey"
  }
pda commented 6 years ago

Looks like this is fixed on master since the latest v0.0.2 tag; in e076f44021a2797514b0e3fe553a0a5c86bd5c3b and/or 63f760cf5f62aecdf5cb3ef57f2ea10fb3011726 (#7). I plan to tag a release this week, hopefully including ParameterStore integration in #9.