search

cultureamp / react-elm-components

Write React components in Elm
https://www.npmjs.com/package/react-elm-components
BSD 3-Clause "New" or "Revised" License
779 stars 54 forks source link

Extending React.Component rather than using createClass #14

Open julienmachon opened 7 years ago

julienmachon commented 7 years ago

With React 16 coming soon and removing createClass from the main React package I just re-implemented the component extending React.Component.

I saw PR #11 trying to solve the same issue by adding create-react-class as a dependency. I reckon most people are running node v4+ so probably no need for adding that dependency.

I've simply re-implemented it "as is" without questioning the logic but if we get rid of the life-cycle method shouldComponentUpdate this could simply be a pure function.

joshhornby commented 7 years ago

@evancz Can this be merged? :)

Voronchuk commented 7 years ago

I guess you shouldn't use uncompiled ES6 as it will break a lot of 3rd party deps, should export a compiled version.

sentience commented 6 years ago

This seems to be obsolete now that #11 has merged.