Closed 5outh closed 7 years ago
See #3. Basically, this component doesn't currently handle the full React component lifecycle.
Same issue with storybook
To be clear - I'm mostly looking for clarification on what this library is meant to be - If it's meant as a 20 line starting point for more robust, custom implementations, then nothing needs to be done (except a README update). If it's meant as the go-to library for integrating react with elm, there should be some work done on that front.
I get the feeling that the project is meant as the former, but it's not explicitly mentioned anywhere.
Should be fixed by #5
Fixed in 1.0.1
- thanks @MoeSattler!
As to the question of this library's role, I see it primarily as a simple starting point, but avoiding problems in common cases like this still seems reasonable. 🙂
Thank you both!
Overview
If
node
is nonexistent ininitialize
, the following error occurs, and the application breaks:This happens when switching routes with react-router that have the same elm component embedded. It's easy to fix, by just ignoring null nodes:
But, I don't know if:
a) That really solves the root of the problem, or b) it is a necessary addition, considering this library is meant as an example for implementors.
Ideas?