search

culturecreates / footlight-aggregator

A tool to inject entities from Artsdata to footlight
0 stars 0 forks source link

Load event series from Artsdata #15

Closed saumier closed 1 year ago

saumier commented 1 year ago

As a user of the Footlight Aggregator, I can load Event Series from Artsdata. An Event in Artsdata can be an Event Series with subEvents.

saumier commented 1 year ago

@dev-aravind Please check the doc for my JSON examples: https://docs.google.com/document/d/1AOUiZD3wh-J3M1UDpwBjMhBZm2HfhM_8_NgWCy74LLg/edit#heading=h.kob2runjstz

dev-aravind commented 1 year ago

Added support to load event series using footlight-aggregator.

saumier commented 1 year ago

@dev-aravind Great. I saw that the test event Rosalie Vaillancourt was loaded in staging. What other combinations of start and end date/times are supported? Please answer this question in the doc https://docs.google.com/document/d/1AOUiZD3wh-J3M1UDpwBjMhBZm2HfhM_8_NgWCy74LLg/edit#heading=h.kob2runjstz

saumier commented 1 year ago

@dev-aravind Please add support for all combinations of startDate/startDateTime and endDate/EndDateTime.

sahalali commented 1 year ago

With the current implementation, we support only startDate or startDateTime for custom dates. The endDate or endDateTime is automatically set to the end time of the start date.

We can add support to startDate through the aggregator.

saumier commented 1 year ago

@troughc I'd like to review the priority of supporting this special case of Event Series. There are currently no upcoming Event Series in Gatineau cloud in this special case of End date different than Start date, and if there were, we can't display this is the CMS yet because there is no endTime in custom dates. So I propose we move this out of scope until we have complete migrating all old CMS over. Currently Event Series that fall in this special case are stored in Artsdata (collected by Console) but not sent to CMS. Let me know if you agree.

SPARQL to find Event Series with subEvents endDates on a different day than the startDate. https://s.zazuko.com/2mKaGks

troughc commented 1 year ago

@saumier I think the above comments sounds like its about an edge case for Event series so it is probably okay since we would get the bulk of event series through. Is my understanding correct? Can you please add an example of this type of event series for me to look at? Thanks?

troughc commented 1 year ago

@saumier how would I test this?

saumier commented 1 year ago

@troughc I am testing it.