search

culturecreates / footlight-aggregator

A tool to inject entities from Artsdata to footlight
0 stars 0 forks source link

Aggregator mapping data #55

Closed saumier closed 1 year ago

saumier commented 1 year ago

The data files should be published as they appear in the main branch. The idea of a "data" branch was introduced to facilitate using GitHub pages for making files in a private repo available via url. But this approach is prone to errors because it requires an extra step of publishing a branch and is difficult to trace.

A better solution is to link directly to the URL of the raw data JSON file. The GitHub Pages option can be deactivated and the data branch deleted.

Related issue https://github.com/culturecreates/footlight-aggregator/issues/51

saumier commented 1 year ago

@sahalali I think we should update the URLs in the workflows to point to the raw data JSON. Unless you see a reason not to. When I look into the workflows they still point to the GitHub pages -m https://culturecreates.github.io/footlight-aggregator/data/salle-odyssee-cms-mapping.json but they should point to https://raw.githubusercontent.com/culturecreates/footlight-aggregator/main/data/salle-odyssee-cms-mapping.json which does not depend on GitHub pages.

Once you point to the raw Github files, we can remove GitHub Pages and it will no longer do extra deploys to GitHub Pages every time we commit. Do you agree?

sahalali commented 1 year ago

Updated github action scripts. Deleted the brach "data". Deleted github pages. Tested Aggregator running with the new URLs

saumier commented 1 year ago

@sahalali Great. Thx. I think this setup is simpler and easier to use. In the future please share your thoughts if you see any issues using raw Github files. I'll close this issue now.