bugs when creating a new taxonomy

[troughc]

• there is no admin only field included when you are mapping a new taxonomy to an existing field.

• You should not be able to change class type in the second screen (you choose it on the first screen). This is not true when you are creating a taxonomy for an existing or new field. the class type should be grayed out

• I am getting an error in staging when I try to create and SAVE a new taxonomy in Tout Culture - (test taxonomy). It said it already existed, however, it then created it anyway

I think Taxonomies needs to be retested thoroughly.

[SyamBabu-M]

@dev-aravind there seems to be a backend issue while saving taxonomy. Please look into this.

[dev-aravind]

@SyamBabu-M The bug is fixed in staging please have a look and let me know if you find any issues.

[SyamBabu-M]

@dev-aravind I just found a new bug in taxonomy. There is an issue with how adminOnly is handled in the add taxonomy API. It works fine with edit taxonomy API. Please look into this.

[dev-aravind]

@troughc This is fixed in staging now. You can check the linked PR to test this.

[troughc]

Tests: Tested: there is no admin only field included when you are mapping a new taxonomy to an existing field. PASSED

Tested: You should not be able to change class type in the second screen (you choose it on the first screen). This is not true when you are creating a taxonomy for an existing or new field. the class type should be grayed out: PASSED

Tested: I am getting an error in staging when I try to create and SAVE a new taxonomy in Tout Culture - (test taxonomy). It said it already existed, however, it then created it anyway

• this worked, I was able to save a new custom taxonomy. However, I was able to create a taxonomy of the same name as another (Place type in places) and, then when I wanted to delete it I got the following message (and my taxonomy is not connected to anything):

[troughc]

Two new issues have been discovered when testing this:

• the error shown above (regarding a wrong count in the popup message that appears when I trash the taxonomy) happens when I don't add any concepts during taxonomy creation. In other words, I am creating a taxonomy without any controlled vocabulary. Once you add at minimum one concept the error count goes away. Expected behaviour: error count is 0 until a taxonomy is actually used for an entity
• a user can create a taxonomy of exactly the same name for the same class type. For example, I can create multiple taxonomies named Place type for Place class. @sahalali, will this cause problems in the backend API? In terms of the CMS this seems like it would be confusing for users. Expected behaviour: taxonomies should be uniquely named within a class type.

@sahalali should these bugs be addressed in this issue or should we open a new issue?

[sahalali]

Can you please review this in prod?

[troughc]

Hey there, whilst writing up the help guide, I tried to make Disciplines and Event types available as a Filter from the Signe Laval calendar. When I tried to save the taxonomy I got an error message - that the name was already used. I think this is because Maude from Signe Laval renamed Event type 'Discipline" and then created a custom taxonomy called "Event type" (but all in French). @AbhishekPAnil you can ask @saumier about this if you don't remember - I may not be in the meeting tomorrow (but I will try to join).

Custom taxonomy:

Renamed Standard taxonomy:

[AbhishekPAnil]

Can you please review this in prod? @sahalali I tested this in prod and this is working fine in production.

[AbhishekPAnil]

cc @AbhishekPAnil Test the issue Caitlin in the above comment https://github.com/culturecreates/footlight-app/issues/1129#issuecomment-2153095291.

[AbhishekPAnil]

cc @SyamBabu-M Please check and rectify this code and its other parts .

<Col style={{ flex: '1' }}>
                        <DateAction
                          iconrender={<PlusOutlined style={{ fontSize: '24px' }} />}
                          label={t('dashboard.taxonomy.selectType.newField')}
                          style={{ height: '104px', padding: 16 }}
                          onClick={() => navigationHandler('not-dynamic')}
                        />
                      </Col>
                      <Col style={{ flex: '1' }}>
                        <DateAction
                          data-cy="button-taxonomy-existing-field"
                          iconrender={<DatabaseOutlined style={{ fontSize: '24px' }} />}
                          label={t('dashboard.taxonomy.selectType.existingField')}
                          disabled={standardFields.length < 1 && selectedClass.label !== '' ? true : false}
                          style={{
                            height: '104px',
                            padding: 16,
                            ...(standardFields.length < 1 && selectedClass.label !== '' && buttonStyles),
                          }}
                          onClick={() => navigationHandler('dynamic')}
                        />
                      </Col>

I think there might be a logical issue here and that might have caused the mappedToField to appear in the backend.

[SyamBabu-M]

@AbhishekPAnil I have added the potential fix.

[troughc]

Make sure that user cannot create two taxonomies of same name in the same class. Make sure that standard and dynamic taxonomies can be created and updated. copy paste current create a new taxonomy link into a new tab and try to create a new dynamic taxonomy from there.

[troughc]

Tested on Chrome

1. Make sure that user cannot create two taxonomies of same name in the same class: When I try to save a new taxonomy with same name of an existing taxonomy in the same class, I get sent to an error page:

Expected behaviour: Instead, I should see this message but stay on the page (similar to the one shown above, but reworded). Ideally I would like the message to appear in red below the Taxonomy name field. If this is not possible, please use a popup message. English This taxonomy name is already taken. Please choose another name.
French Ce nom de taxonomie est déjà pris. Veuillez choisir un autre nom.

2. Make sure that standard and dynamic taxonomies can be created and updated: PASSED
3. copy paste current create a new taxonomy link into a new tab and try to create a new dynamic taxonomy from there: I copied the link of the first page (where you select your class) to a new tab and then continued creating a new taxonomy: PASSED I then copied the link of the next page, (where you fill in the details) to a new tab: the new tab always shows a CUSTOM details page, with Event selected (irregardless of what i selected - for example if I selected place/standard taxonomy, in the copied URL, I go to event custom details). That's a bit strange, but it doesn't cause any problems so I am not worried about it: PASSED

[troughc]

@AbhishekPAnil can you deploy this one too? cc @SyamBabu-M