culturecreates / footlight-app

Footlight CMS Front-end
https://cms.footlight.io
3 stars 0 forks source link

addPlace triggers Oops page #1415

Closed kmdvs closed 3 weeks ago

kmdvs commented 1 month ago

I got a few times the Oops page when trying to modify a place

A number of errors in the console: 2024-10-23 02_59_10-Greenshot

Repro:

AbhishekPAnil commented 1 month ago

Bug report : The issue happened with the introduction of new feature to display maps in the create place page #1294 .Some place didn't have coordinates ,hence the map was throwing an error.I have handled this in the frontend. The fix is now updated in staging.

troughc commented 1 month ago

@kmdvs we are curious, how did you discover this bug? Was it found by using the regression test? cc @saumier @dev-aravind

Also, please test and set to be deployed if it passes your test.

kmdvs commented 1 month ago

@troughc Yes, it was discovered as I was updating the code for regression tests and I was repeatedly getting the Oops page. I tested it after Abhishek put a fix on staging and I didn't get the error page anymore.

troughc commented 1 month ago

@troughc Yes, it was discovered as I was updating the code for regression tests and I was repeatedly getting the Oops page. I tested it after Abhishek put a fix on staging and I didn't get the error page anymore.

FYI @saumier