culturecreates / footlight-app

Footlight CMS Front-end
https://cms.footlight.io
3 stars 0 forks source link

Error in passing containsPlace and containedInPlace #1438

Closed AbhishekPAnil closed 6 days ago

AbhishekPAnil commented 2 weeks ago

Create a place with all the necessary details ,make sure to add contains place and contained in place from the 'Import from Footlight' section. Current Behaviour : The selected contains place and contained in place are not seen in the read only page and edit page for the saved place.

Expected Behaviour : The contains place and contained in place should be properly passed in payload for all the sources. Note : This happens only for imports from footlight entities.

@AbhishekPAnil Please also check the creation of entities in the respective calendar ,from other calendars while using the imports from footlight section.

troughc commented 2 weeks ago

@sahalali according to our discussion today, the plan is to support adding a place to the "contained in" or "contains" fields from another footlight calendar in the same way as we do from Artsdata. And, when we add entities, we follow the model we chose for Artsdata. Examples of what we do:

Please confirm this is your understanding of what backend work is needed? I am assigning this issue to you.

cc @AbhishekPAnil

troughc commented 1 week ago

@sahalali @saumier here is a link to the Guidelines for importing entities from external sources to Footlight CMS cc @AbhishekPAnil

troughc commented 1 week ago

Oops @AbhishekPAnil I don't seem to be able to log into the PR.

AbhishekPAnil commented 1 week ago

@troughc You can test this in staging or in production.The changes are updated in both.

troughc commented 6 days ago

Tested in staging via Tout Culture and Signe Laval calendars. Seems to work as expected. PASSED.