search

culturecreates / footlight-app

Footlight CMS Front-end
https://cms.footlight.io
3 stars 0 forks source link

multiple dates: no way to add an end time within the Edit (customize) module #261

Open troughc opened 1 year ago

troughc commented 1 year ago

As a user I may start to create my multiple date event using daily or weekly to set up the basic parameters, including start time and end times that happen on all dates. I then want to customize, maybe add extra start/end times on some days or extra days. What happens now:

  1. I set up a weekly recurring event with start time and end time
  2. When I click Edit, the end time I set up is no longer included (only the start time and dates). I must delete the time from one event and then add a new entry that includes start and end times and save. Then click duplicate to add it to all other events.
  3. BUG: If I don't delete it FIRST (before adding a new time), I cannot delete after - when I try, it deletes both my times (they seem to be linked). This seems to only happen in this case (where the times are overlapping)

Questions:

  1. can we bring the end time in along with all the other data (dates and start times)?
  2. Why can't i delete the 'old/imported' start time after adding a new time (with start and end time) without deleting both?
troughc commented 1 year ago

@saumier can we discuss this one? There is an issue regarding bringing end times into the customize dialog. Example event: http://staging.cms.footlight.io/dashboard/62df90a4820e41f7c1359760/events/add-event/641c37df7b9df310888fcc84

saumier commented 1 year ago

@troughc This should be looked at by Abhishek. I'll add this as a bug to the iteration 3 after feature freeze. You can re-prioritize if needed.

troughc commented 1 year ago

@saumier regarding the email from Eric (in Erreur - Heure et billet (Error - Time and Ticket)) where he says:

_There are different rules in the code and right now the condition is checking that there is an end time to show times. Can you do an Isabelle test to confirm that this is indeed the case? That would allow for a quick fix.

On our side, we will add the condition and at the same time we will modify the date display logic. It should follow next week. Is it good for you Isabelle?_

Does this issue impact the results?

saumier commented 1 year ago

@troughc Is this a question for me? I am not sure what is being asked.

I can say that the end time is optional in the Footlight API.

For example, an event with a single occurence can have a start time without an end time. In music events there is often no end time. Also, an event series with multiple occurrences can have start times without end times. An example is a music events happening on 2 days. Does that help?

troughc commented 1 year ago

@saumier you are in the email thread with Eric and Isabelle so you probably know better than I since it was a technical question. I would ask that you confirm in the email thread. I guess then, that this bug has no impact on the issue with MINIMAL. .. Thanks.

saumier commented 1 year ago

@troughc This issue has a workaround. To edit the times you need to delete the times and enter new ones. I moved this back out of ToDo. If you feel we cannot live with this workaround, then please raise the priority of this issue by placing back in the ToDo column. Thx.