Closed saumier closed 10 months ago
@SyamBabu-M please assign this issue to me after you do the estimate.
@troughc I have some doubts regarding this tickets. Can we discuss this in todays standup?
Estimate of 24 hours by Syam.
UPDATE to design from the client (slightly different from the mockup design): MRC des Collines-de-l’Outaouais would like to have Events in one tab and workshops in another tab in the widget (just like they are right now). @SyamBabu-M I will now assign to you, let me know if you have any questions. cc @saumier
@SyamBabu-M I have updated the Readme with my suggested parameters and created a PR here https://github.com/culturecreates/minimal-footlight-search-widget/pull/82
Please review and let me know if you have any questions or ideas to do the configurations differently. You can merge the PR if you agree with the changes.
@saumier I have merged the PR. The suggestions looked great to me.
@troughc Is the design completed?
Blue line is external to the widget. Design is complete, keeping in mind that there are 2 tabs Events and Workshops.
@troughc please do a first pass and I will do a second
@saumier @troughc http://demo.staging-tout-culture.s3-website.ca-central-1.amazonaws.com/ http://staging.minimal-footlight-search-widget.s3.ca-central-1.amazonaws.com/v2/test-dist.html
please use these links to test the widget.
Tested on chrome, this link: http://staging.minimal-footlight-search-widget.s3.ca-central-1.amazonaws.com/v2/test-dist.html
Search bar seems to be working as expected: PASSED Two tabs - Events and Workshops with correct lists: PASSED click an event to get to event on tout culture website (in new tab): PASSED click see all results to get to list of filtered resulst on tout culture website (in new tab): PASSED select specific dates to sort: PASSED Select date range: PASSED
@SyamBabu-M Two questions:
Ready for you @saumier
@troughc The link with the 3 tabs is relevant because it is the new widget that will be seen on toutculture.ca. So we need to test that the new widget works in both places at the same time.
The region ID for collines de l'outouais is 63bc0b2d1c6b6c005aad5253
@SyamBabu-M I did some testing and there are things that need to be fixed. Please work on this as a priority so I will be able to test again tomorrow end of your day. Below is my list divided into MUST FIX and NICE TO HAVE. Please only do the must fix and after you have tested the must fix and you still have time then you can work on the nice to have.
MUST FIX
NICE TO HAVE
Tested: PASSED
The footer label says no events are found, but there are events. Label is incorrect.
@troughc I found a bug in the footer label (see above) so I am assigned back to Syam.
@troughc I tested and it looks good. I am pushing to production.
@SyamBabu-M here are the links: Customer site: https://mrcdescollinesdeloutaouais.qc.ca/nos-services/culture/ Culture Creates site (blog post): https://culturecreates.com/calendar-widget/ Please look at it on different platforms. @saumier will provide feedback that can also feed into phase 2 (and provide direction to fix a few things in this one)
@SyamBabu-M Issues with the Minimal widget:
@SyamBabu-M Please be careful with the test-dist.html file. It must remain configured for MRC's website. They are using this page in their iframe in their live website. When you add the param to "open in a new window" please set the default to "same window" and add the new param for "open in new window" to the test-dist.html file so MRC's widget will work as expected.
Once you have updated V3, please test on both:
@saumier you can access the test page using the link given below. http://staging.minimal-footlight-search-widget.s3.ca-central-1.amazonaws.com/v3/test-iframe.html
test according ot the MRC story:
@SyamBabu-M What is the status? I need to let the client know when they can start using v3 on the Minimal site. Does the default click in production now open in the same window?
@saumier Yes it will open in the same tab. I have added a PR
@troughc Have you tried the widget on MRC with the click opening in the iframe instead of opening a new window? It is interesting. Maybe even better? Try it out and let me know what you think.
@saumier in my marketing experience customers (i.e. a customer like Tout Culture) often use a widget like this as a way of:
We would like to use the same widget for another 3rd party site. In this example, another web site in the region of Outaouais is called "MRC Collines-de-outaouais".
Features to add to html for installing the widget on another website:
Additional request from Minimal for the search widget: