search

culturecreates / testbench

Web application to try out reconciliation services interactively
https://culturecreates.github.io/testbench/#/client/https%3A%2F%2Fapi.artsdata.ca%2Frecon
MIT License
0 stars 0 forks source link

Reconciliation Test Bench POST #1

Closed saumier closed 4 months ago

saumier commented 4 months ago

@dev-aravind Commented that the Reconciliation API spec only accepts POST requests but the test bench is currently using GET. I proposed to the Reconciliation CG that we update the Test bench and they agreed.

Reconciliation CG April 2024 meeting notes:

saumier commented 4 months ago

@AbhishekPAnil I think this would be a good task for you. The test bench is in React. I think this could be a good contribution from Culture Creates to this W3C open group. You would also see how the project is setup in Github (they also use Netlify to preview PRs) and how they call the Reconciliation API and run unit tests.

This should be done by first week of May 2024.

@sahalali @AbhishekPAnil Let me know if you can take this on in your current work load. I suggest you take a couple hours to look at the react test bench and see if you can get it running locally on your machine. Then I can explain the changes needed.

saumier commented 4 months ago

@AbhishekPAnil When making changes to the test bench, please refer to the lastest published spec which is https://www.w3.org/community/reports/reconciliation/CG-FINAL-specs-0.2-20230410/

The group is working on a new version of the spec which has breaking changes, so until the draft is officially published the official W3C test bench should follow version 0.2 listed above.

saumier commented 4 months ago

@AbhishekPAnil I propose you make your changes in this forked repo. It is synched with the original testbench. It also deploys on one of our Github pages for testing https://culturecreates.github.io/testbench/. Then we can submit the contribution. First we can test on the branch that gets deployed to culture creates Github pages. The trigger for the Github action to publish the website is when master is pushed to gh-pages branch.

saumier commented 4 months ago

@AbhishekPAnil Your code changes look good, but I am having trouble running the tests (the existing ones) and I am not sure which version of node I should be using. Which version of node did you use and did the existing tests pass?

AbhishekPAnil commented 4 months ago

@AbhishekPAnil Your code changes look good, but I am having trouble running the tests (the existing ones) and I am not sure which version of node I should be using. Which version of node did you use and did the existing tests pass?

Can you try it with node 15,thats the onementioned in the workflows.For me it worked with 14 as well.

I didn't try out the tests as I didn't see any existing tests written other than the default App.test.