cumc / pecotmr

Pair-wise enrichment, colocalization, TWAS and Mendelian Randomization to integrate molecular QTL and GWAS.
Other
11 stars 12 forks source link

Feature roadmap #36

Open danielnachun opened 9 months ago

danielnachun commented 9 months ago

As our work on this package progress, this issue can help us enumerate possible future features of the package depending on the time and interests of contributors. Some features will be needed for the manuscript submission, and others will make more sense to consider for future releases.

TWAS

Individual

Summary

Longer term

Mendelian randomization

Colocalization

Polygenic molecular risk scores (PMRS)

Interfaces with other packages

Other

gaow commented 8 months ago

 mr.ash priors

Not sure if mr.ash package itself accepts these other models. We might have to implement if we want. I would suggest we stick to the originaly published.

 vignette for CTWAS - currently challenging to run CTWAS

As of now the main branch for cTWAS is broken. I've talked to people in Xin's group -- it should be possible to involve them in the xQTL project focused on delivering this part. I'll talk to Xin more formally in the following couple of weeks.

gaow commented 6 months ago

Updates on the original post

  1. cTWAS -- my team is working actively with Xin's to refactor the package but still WIP
  2. mr_ash_rss Rcpp is roughly done: we still need to compare it against the individual level, add additional parameters to be consistent with that, and also add some omp on the loops to parallel, just like what we do for other Rcpp applications under src
  3. prs_cs Rcpp is roughly done. It is hard to compare numerically with the original implementation (MCMC by nature) but we should need another pair of eyes to read compare manually line by line if we did the right thing. I have done that myself I think it seems fine.
danielnachun commented 4 days ago

I recently reread the SuSiE-inf paper (https://pubmed.ncbi.nlm.nih.gov/38036779/) and now understand that this model is really just extending SuSiE to do variance components estimation to handle stratification instead of residualizing ancestry PCs. I have some ideas on how to do this in a way that is more suitable for QTLs and could be treated as a 'pre-processing' step rather than having to modify how SuSiE itself runs. This approach could also be make to work with mr.ash or other penalized regression methods. Importantly, nothing in pecotmr would need to be modified for any of this to work, including the original implementation of SuSiE-inf. Consequently I've cleaned up and corrected various mistakes in my original post to incorporate this knowledge along with some other topics as well.