search

cumc / xqtl-protocol

Molecular QTL analysis protocol developed by ADSP Functional Genomics Consortium
https://cumc.github.io/xqtl-protocol/
MIT License
38 stars 42 forks source link

gene_annotation:convert ProjID to SampleID #873

Closed al4225 closed 6 months ago

al4225 commented 6 months ago

convert first column to second column: convert ProjID to SampleID

review-notebook-app[bot] commented 6 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

gaow commented 6 months ago

Still, the previouls code assumes \t but your updated is ,. Why don't we stick to \t? This seems to be breaking the previous anlaysis code if I merge the change?

al4225 commented 6 months ago

Still, the previouls code assumes \t but your updated is ,. Why don't we stick to \t? This seems to be breaking the previous anlaysis code if I merge the change?

Cuz the reference data sampleSheetAfterQc.csv is a csv file and uses ','. If we stick to \t, it will return an error.

gaow commented 6 months ago

then we should make that an option. parameter input comma or tab ?

al4225 commented 6 months ago

yes thanks I can do that.

发件人: gaow @.> 发送时间: 2024年2月26日 17:07 收件人: cumc/xqtl-pipeline @.> 抄送: Liu, Anjing @.>; Author @.> 主题: [EXTERNAL] Re: [cumc/xqtl-pipeline] gene_annotation:convert ProjID to SampleID (PR #873)

then we should make that an option. parameter input comma or tab ?

― Reply to this email directly, view it on GitHubhttps://github.com/cumc/xqtl-pipeline/pull/873#issuecomment-1965383382, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2575WQQMGJVNGKBNJNFPVTYVUBQ7AVCNFSM6AAAAABD27MA76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRVGM4DGMZYGI. You are receiving this because you authored the thread.Message ID: @.***>

al4225 commented 6 months ago

Already modified code considering \t and ,.