update AD post processing

cumc / xqtl-protocol

Molecular QTL analysis protocol developed by ADSP Functional Genomics Consortium

https://cumc.github.io/xqtl-protocol/

MIT License

38 stars 42 forks source link

update AD post processing #874

Closed rfeng2023 closed 6 months ago

rfeng2023 commented 6 months ago

using lapply instead of for loop here, as I think I am loading exported qtl file anyways, it should not cost too much memory, please let me know if that is not acceptable @gaow

review-notebook-app[bot] commented 6 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

gaow commented 6 months ago

@rfeng2023 thanks! It's a bit hard for me to digest it at this point ... (i even stared at the title of this PR "Adpost" for quite a while trying to figure out what that word means). I guess as long as we can verify the outputs are correct, we are more or less reassured. One thing to caution is that next release of top_loci table will be NULL if there are no rows. So has_rows() related function will be broken. We can talk tmr.