Closed rfeng2023 closed 6 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@rfeng2023 I accepted partially your changes, see here:
https://github.com/cumc/xqtl-pipeline/commit/b027f8a376d8f813894e95b3e3a4192fc0ade9b2
However as I indicated in our slack conversation, I don't like how you recover tuple from the strings. My suggestion was this:
please try that suggestion. Please first sync the repo so you get the updates first -- file names are also changed.
which is not from this commit, and I don't know what does that mean...
sorry my bad -- fixed here: https://github.com/cumc/xqtl-pipeline/commit/c83e62c3f67aef6d695bfc2bb34434fc10976a8d
the script is reporting error
which is not from this commit, and I don't know what does that mean... I tested region names with a separate cell which works well.