search

cumc / xqtl-protocol

Molecular QTL analysis protocol developed by ADSP Functional Genomics Consortium
https://cumc.github.io/xqtl-protocol/
MIT License
38 stars 42 forks source link

accomodate s3 path #905

Closed hsun3163 closed 6 months ago

hsun3163 commented 6 months ago

Counterintuitively, the output path of aws runs is effectively empty. So additional parameter are needed to account for the differences.

review-notebook-app[bot] commented 6 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

gaow commented 6 months ago

@hsun3163 thanks ! this was counter intuitive to me in the beginning but if you think of github files vs folders it's the same thing: there is no such a concept as folders on github or AWS. Its always about files. With that in mind perhaps you see it starts to make sense (hopefully you get what i mean)