search

cumulusmx / CumulusMX

The Cumulus MX weather program
GNU General Public License v3.0
84 stars 24 forks source link

Speed up of ExportMySQL #104

Closed HansR00 closed 3 years ago

HansR00 commented 3 years ago

Speed up of the ExportMySQL utility

1) Accidental update of ServiceStack.text to 5.10.4 (but should be no problem, easy to skip otherwise) 2) The actual changes consist of a loop ruled by MaxBatchSize Unfortunately the indentation has created more diffs than necessary making it somewhat hard to see what has actually changed. It is just an added for loop to create the query.

mcrossley commented 3 years ago

Hi Hans, thanks for this - shame about the formatting! ;)

I'm going to close this PR as it affects the main Cumulus MX program as well.

I am in the process of removing ExportMySQL from the main CumulusMX repo, and give its own like CreateMissing. I have incorporated your bulk insert changes in the new version though.

HansR00 commented 3 years ago

Hi Mark, OK. Will find the repo when it's there I guess, will be under the cumulusmx account I assume. Did I finally do a pull request on the CMX repo ... ;) Oh and the formatting was my fault. Should have tagged to ignore white space, it looks much better then. Thanks for picking it up.

mcrossley commented 3 years ago

Please see: https://github.com/cumulusmx/ExportToMySQL