Dev tempest station - Githubissues

jokerboy commented 2 years ago

Mark, (Doug again)

Here's the PR for the integration of the WeatherFlow Tempest station.

Let me know if you have any issues with the changes.

mcrossley commented 2 years ago

Merged, but a request... Can you respect the original files line endings and tabs please.

By default across the project I am trying to use Unix (LF) line endings and indents use tabs.

Thanks

jokerboy commented 2 years ago

Thanks Mark!

I'll fix the line endings & tabs in the next PR

Doug

On Mon, Aug 16, 2021 at 9:08 AM Mark Crossley @.***> wrote:

Merged, but a request... Can you respect the original files line endings and tabs please.

By default across the project I am trying to use Unix (LF) line endings and indents use tabs.

Thanks

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cumulusmx/CumulusMX/pull/118#issuecomment-899631582, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABQBTAVUUSM34CMFGBC66TT5EZWNANCNFSM5CDNOBNA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

jokerboy commented 2 years ago

Hi Mark,

Are you wanting just the distributionfiles project to have unix file endings? because as far as I can tell all of the ".cs" files in the CumulusMX project are using windows line endings.

Thanks,

Doug

On Mon, Aug 16, 2021 at 9:55 AM Doug Summersgill @.***> wrote:

Thanks Mark!

I'll fix the line endings & tabs in the next PR

Doug

On Mon, Aug 16, 2021 at 9:08 AM Mark Crossley @.***> wrote:

Merged, but a request... Can you respect the original files line endings and tabs please.

By default across the project I am trying to use Unix (LF) line endings and indents use tabs.

Thanks

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cumulusmx/CumulusMX/pull/118#issuecomment-899631582, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABQBTAVUUSM34CMFGBC66TT5EZWNANCNFSM5CDNOBNA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

jokerboy commented 2 years ago

Mark,

I think git/github is converting the line endings to 'lf' when I push the changes so perhaps the only issue is the tabs. I'll work to get those fixed.

Regards,

Doug

On Mon, Aug 16, 2021 at 10:39 AM Doug Summersgill @.***> wrote:

Hi Mark,

Are you wanting just the distributionfiles project to have unix file endings? because as far as I can tell all of the ".cs" files in the CumulusMX project are using windows line endings.

Thanks,

Doug

On Mon, Aug 16, 2021 at 9:55 AM Doug Summersgill @.***> wrote:

Thanks Mark!

I'll fix the line endings & tabs in the next PR

Doug

On Mon, Aug 16, 2021 at 9:08 AM Mark Crossley @.***> wrote:

Merged, but a request... Can you respect the original files line endings and tabs please.

By default across the project I am trying to use Unix (LF) line endings and indents use tabs.

Thanks

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cumulusmx/CumulusMX/pull/118#issuecomment-899631582, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABQBTAVUUSM34CMFGBC66TT5EZWNANCNFSM5CDNOBNA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

cumulusmx / CumulusMX

Dev tempest station #118