disconnect_on_error issue with Redis 4.5.5

cunla / fakeredis-py

Implementation of Redis in python without having a Redis server running. Fully compatible with using redis-py.

https://fakeredis.moransoftware.ca/

BSD 3-Clause "New" or "Revised" License

298 stars 48 forks source link

disconnect_on_error issue with Redis 4.5.5 #149

Closed alor closed 1 year ago

alor commented 1 year ago

Describe the bug tests are failing with: FakeConnection.read_response() got an unexpected keyword argument 'disconnect_on_error' if redis 4.5.5 is used.

works fine if redis 4.5.4 is used.

this could be related to this change in Redis:

Revert #2104, #2673, add disconnect_on_error option to read_response() (issues #2506, #2624)

To Reproduce use redis version 4.5.5 in conjunction with fakeredis

cunla commented 1 year ago

This is already fixed in the code. I'll publish the new release this weekend

cunla commented 1 year ago

v.2.12.1 released