search

cunla / fakeredis-py

Implementation of Redis API in python without having a server running. Fully compatible with using redis-py.
https://fakeredis.moransoftware.ca/
BSD 3-Clause "New" or "Revised" License
300 stars 49 forks source link

Implement support for `TOPK.RESERVE` (topk command) #265

Closed cunla closed 10 months ago

cunla commented 11 months ago

Implement support for command TOPK.RESERVE in topk_mixin.py.

Initializes a TopK with specified parameters.

Here is the Official documentation

andret13pinto commented 10 months ago

Hey, I would like to work on this.

cunla commented 10 months ago

Hi, thanks for jumping in. I started creating a skeleton for it here.

Feel free to fork and continue working on it, as I won't have time this month.

Let me know if you have any questions.

andret13pinto commented 10 months ago

@cunla sure will do. Was thinking of building a separate package for the HeavyKeeper datastructure, would you mind importing it, instead of adding it here as part of the source code?

cunla commented 10 months ago

See the file. I started implementing the HeavyKeeper class... not sure whether that class merit its own package.

andret13pinto commented 10 months ago

Ok. I will continue from there.

cunla commented 10 months ago

Do you have an ETA when you finish it? I want to release a new version and it would be great if this is in it.

andret13pinto commented 10 months ago

1 to 2 week max

cunla commented 10 months ago

any update on this?

andret13pinto commented 10 months ago

Actually something came up that's impossibilating me to work on this. Sorry, maybe next time will be able to contribute 😄