Closed ulmus closed 9 months ago
I believe that the failing test is not based on any changes in this PR, since it only touches documentation.
Hello, FYI I cannot run the test with the new settings with CONNECTION_POOL_KWARGS
.
The old setting works for me. Can you verify this please?
What version of django are you using?
@ulmus, do you mind confirming?
I'm using Django 4.2.7
.
Here is the error I got:
TypeError: AbstractConnection.__init__() got an unexpected keyword argument 'CONNECTION_POOL_KWARGS'
I'll revert the changes for now. Thanks for bringing this up!
I verified and CONNECTION_POOL_KWARGS
is an option for 3rd party package django-redis.
However, the example given in the docs is for official implementation of Django Redis.
This explains the confusion.
ok, that makes sense. Do you mind adding a section in the documentation explaining that? (django out-of-the-box redis cache vs. django-redis cache)
Done !
Good catch! That was why it didn't work for me. Good to have both options described!
Update the documentation to reflect that django test settings need to be set in the CONNECTION_POOL_KWARGS key