cunla / fakeredis-py

Implementation of Redis in python without having a Redis server running. Fully compatible with using redis-py.
https://fakeredis.moransoftware.ca/
BSD 3-Clause "New" or "Revised" License
298 stars 48 forks source link

Stray `LICENSE` installed into site-packages #320

Closed mgorny closed 2 months ago

mgorny commented 2 months ago

Describe the bug The package installs a stray LICENSE file to the top directory of site-packages.

To Reproduce

$ pip install fakeredis
Collecting fakeredis
  Downloading fakeredis-2.24.0-py3-none-any.whl.metadata (3.8 kB)
Collecting redis>=4 (from fakeredis)
  Using cached redis-5.0.8-py3-none-any.whl.metadata (9.2 kB)
Collecting sortedcontainers<3,>=2 (from fakeredis)
  Using cached sortedcontainers-2.4.0-py2.py3-none-any.whl.metadata (10 kB)
Downloading fakeredis-2.24.0-py3-none-any.whl (97 kB)
Using cached redis-5.0.8-py3-none-any.whl (255 kB)
Using cached sortedcontainers-2.4.0-py2.py3-none-any.whl (29 kB)
Installing collected packages: sortedcontainers, redis, fakeredis
Successfully installed fakeredis-2.24.0 redis-5.0.8 sortedcontainers-2.4.0
$ ls $VIRTUAL_ENV/lib/python*/site-packages
fakeredis                   LICENSE  pip-24.2.dist-info  redis-5.0.8.dist-info  sortedcontainers-2.4.0.dist-info
fakeredis-2.24.0.dist-info  pip      redis               sortedcontainers

Note the LICENSE file that shouldn't be there.

Expected behavior All files installed into fakeredis directory.

Screenshots n/a

Desktop (please complete the following information):

Additional context Apparently this is because LICENSE is listed in tool.poetry.packages.

Upvote & Fund

Fund with Polar

cunla commented 2 months ago

thanks for reporting this. Fixed in 2.24.1

mgorny commented 2 months ago

Thanks.