cunum / unity-osx-notarize

GNU General Public License v3.0
17 stars 1 forks source link

Build issue with Unity2017.4.33 #1

Open tolosafan opened 4 years ago

tolosafan commented 4 years ago

Hello, First: very good idea to create such a plugin. We hate Apple plumberies to be able to run an app on a computer..So thanks and congrats! Second: After installing on U3D 2017.4.33 -unzip the github package -Drag-n-drop all the Editor folder content from unity-osx-notarize-master/Assets/Editor to Editor of our project We got these errors: Assets/Editor/Notarization/NotarizationProcessor.cs(7,25): error CS0234: The type or namespace name Reporting' does not exist in the namespaceUnityEditor.Build'. Are you missing an assembly reference? Assets/Editor/Notarization/NotarizationProcessor.cs(13,41): error CS0246: The type or namespace name `IPostprocessBuildWithReport' could not be found. Are you missing an assembly reference?

Any idea? Thanks,

cunum commented 4 years ago

Hello,

yeah the plugin uses the IPostprocessBuildWithReport interface for post build automatic notarization, this API was introduced in Unity 2018.1, so it doesn't work with Unity versions prior to that. I just pushed a backwards compatible fix, let me know if this does work for you, can't test it myself I'm already on 2019.3.

Best regards

tolosafan commented 4 years ago

Many Thanks for the effort. The previous error has disappeared. But it remains: "Assets/Editor/Notarization/NotarizationProcessor.cs(68,33): error CS0246: The type or namespace name `BuildReport' could not be found. Are you missing an assembly reference?"

cunum commented 4 years ago

Oh yeah, I missed two occurrences, you can pull again, it should work now.

tolosafan commented 4 years ago

Yeah, it builds now. Great & thanks! Let's do some tests with Apple's plumbery..