search

cuny-academic-commons / bp-event-organiser

Allows Event Organiser plugin events to be assigned to BuddyPress groups and generates a group calendar page for each group
GNU General Public License v2.0
3 stars 1 forks source link

Don't `wp_die()` when EO is not active #1

Closed boonebgorges closed 9 years ago

boonebgorges commented 9 years ago

The current is_active() check is a bit heavy-handed. We can probably just bail out of the plugin and throw an admin notice.

r-a-y commented 9 years ago

+1

christianwach commented 9 years ago

Could also add a Depends: plugin header item? It's always a nice surprise to dependencies working when commons-in-a-box is active.

As a side note: it's a weird and humbling thing to watch a plugin being torn apart and rebuilt. I really should have attended to some of the more naive and embarrassing content before the process started!

boonebgorges commented 9 years ago

Could also add a Depends: plugin header item? It's always a nice surprise to dependencies working when commons-in-a-box is active.

Yes, let's!

As a side note: it's a weird and humbling thing to watch a plugin being torn apart and rebuilt. I really should have attended to some of the more naive and embarrassing content before the process started!

Ha, no embarrasment is necessary. You did all the hard exploratory work. Ray and I have the benefit of entering with all the research already done, and laid out in the codebase :)

r-a-y commented 9 years ago

As a side note: it's a weird and humbling thing to watch a plugin being torn apart and rebuilt. I really should have attended to some of the more naive and embarrassing content before the process started!

What Boone said :) We're just enhancing what you've already bulit a foundation for.

I think this plugin is going to rock once we're ready to release it!

mkgold commented 9 years ago

So excited about the work you are all doing. Many thanks!!

BoweFrankema commented 9 years ago

This is great! Great to see this take shape :-)