Closed r-a-y closed 9 years ago
Love it.
On 04/01/2015 02:15 PM, r-a-y wrote:
Regarding #4 https://github.com/cuny-academic-commons/bp-event-organiser/issues/4, this PR uses the Select2 JS library to render group selection in the metabox.
Select2 allows us to use autocompletion to search for groups to add, rather than initially querying all groups to select via checkbox.
Here's a GIF showing how it works: Image of new metabox https://cloud.githubusercontent.com/assets/505921/6948067/2f86d06e-d860-11e4-8998-a5981f131b61.gif
Let me know what you think.
You can view, comment on, or merge this pull request online at:
https://github.com/cuny-academic-commons/bp-event-organiser/pull/12
Commit Summary
Metabox: Use Select2 JS library to render group selection.
File Changes
M bp-event-organiser-eo.php https://github.com/cuny-academic-commons/bp-event-organiser/pull/12/files#diff-0 (178)
Patch Links:
- https://github.com/cuny-academic-commons/bp-event-organiser/pull/12.patch
- https://github.com/cuny-academic-commons/bp-event-organiser/pull/12.diff
— Reply to this email directly or view it on GitHub https://github.com/cuny-academic-commons/bp-event-organiser/pull/12.
Very cool. My only UX comment is that I think that the X is usually aligned to the right (at least in the US), if it's possible for us to change that.
Looks good to me too, @r-a-y.
@mkgold In defense of the left-aligned X, it seems to be consistent with the WordPress Admin UI. See, for example the Tags metabox:
@christianwach Interesting and good point. Let's leave as is, then
@christianwach - One thing I haven't tested is the BP Group Hierarchy plugin with the new metabox. I know you added some type of support for that. Can you do some testing and let me know if anything needs to be adjusted to allow BP Group Hierarchy to work?
@r-a-y Will do that this week - I've been away on an Easter break and am only now catching up on tasks.
Regarding #4, this PR uses the Select2 JS library to render group selection in the metabox.
Select2 allows us to use autocompletion to search for groups to add, rather than initially querying all groups to select via checkbox.
Here's a GIF showing how it works:
Let me know what you think.