cuny-academic-commons / bp-event-organiser

Allows Event Organiser plugin events to be assigned to BuddyPress groups and generates a group calendar page for each group
GNU General Public License v2.0
3 stars 1 forks source link

New method to render metabox #12

Closed r-a-y closed 9 years ago

r-a-y commented 9 years ago

Regarding #4, this PR uses the Select2 JS library to render group selection in the metabox.

Select2 allows us to use autocompletion to search for groups to add, rather than initially querying all groups to select via checkbox.

Here's a GIF showing how it works: Image of new metabox

Let me know what you think.

boonebgorges commented 9 years ago

Love it.

On 04/01/2015 02:15 PM, r-a-y wrote:

Regarding #4 https://github.com/cuny-academic-commons/bp-event-organiser/issues/4, this PR uses the Select2 JS library to render group selection in the metabox.

Select2 allows us to use autocompletion to search for groups to add, rather than initially querying all groups to select via checkbox.

Here's a GIF showing how it works: Image of new metabox https://cloud.githubusercontent.com/assets/505921/6948067/2f86d06e-d860-11e4-8998-a5981f131b61.gif

Let me know what you think.


    You can view, comment on, or merge this pull request online at:

https://github.com/cuny-academic-commons/bp-event-organiser/pull/12

    Commit Summary

— Reply to this email directly or view it on GitHub https://github.com/cuny-academic-commons/bp-event-organiser/pull/12.

mkgold commented 9 years ago

Very cool. My only UX comment is that I think that the X is usually aligned to the right (at least in the US), if it's possible for us to change that.

christianwach commented 9 years ago

Looks good to me too, @r-a-y.

@mkgold In defense of the left-aligned X, it seems to be consistent with the WordPress Admin UI. See, for example the Tags metabox:

screen shot 2015-04-02 at 15 42 11

mkgold commented 9 years ago

@christianwach Interesting and good point. Let's leave as is, then

r-a-y commented 9 years ago

@christianwach - One thing I haven't tested is the BP Group Hierarchy plugin with the new metabox. I know you added some type of support for that. Can you do some testing and let me know if anything needs to be adjusted to allow BP Group Hierarchy to work?

christianwach commented 9 years ago

@r-a-y Will do that this week - I've been away on an Easter break and am only now catching up on tasks.