search

cuny-academic-commons / bp-event-organiser

Allows Event Organiser plugin events to be assigned to BuddyPress groups and generates a group calendar page for each group
GNU General Public License v2.0
3 stars 1 forks source link

Ensure that duplicate emails are not sent in GES #27

Closed boonebgorges closed 9 years ago

boonebgorges commented 9 years ago

If I'm in groups A and B, and if I get immediate GES notifications from both, I should probably not get email notifications of both. Ideally, it'd be a single message that says "Boone created the event 'foo' in groups A and B". I'll have a look at this, as I can probably reuse some of the deduplication logic from the activity stuff.

boonebgorges commented 9 years ago

https://github.com/boonebgorges/buddypress-group-email-subscription/commit/aa6c8f376a878a85920c3cb551ce99ba670cca6b adds a filter to BPGES that I'll use to make this work. bp-event-organiser will only work properly with BPGES 3.6+ as a result (older versions may see duplicate emails).

boonebgorges commented 9 years ago

This is still somewhat rough around the edges - GES sends the canonical URL /events/... for the "View or reply" link, because I can't think at the moment of an easy way to change it to an appropriate group context - but it will work for v1.