search

cuny-academic-commons / bp-event-organiser

Allows Event Organiser plugin events to be assigned to BuddyPress groups and generates a group calendar page for each group
GNU General Public License v2.0
3 stars 1 forks source link

Top-level CPT single view should match group/user context view #31

Closed boonebgorges closed 9 years ago

boonebgorges commented 9 years ago

Currently, they don't look alike at all. Is this totally theme dependent?

r-a-y commented 9 years ago

Are you talking about example.com/events/event/POST-SLUG?

This is handled by EO's default template. I do not think we should do anything for EO's default template.

By that, I mean we shouldn't force the BP interface on it. If we do want to do something, my thoughts are we should just widen the template and make it look less like a WP post.

Widening the template is something that we cannot do for all WP themes due to theme compatibility, but it's something we can do for CAC.

boonebgorges commented 9 years ago

Yeah, I do mean that kind of URL. I agree that we shouldn't force the BP interface on it, but it would be nice if the event-related content were formatted in a way that's reasonably similar to the way it appears in the group and user context. At least in bp-nelo, it's very different. Maybe use a common "event-content" template, and inject it as necessary? (I'm saying this without having looked at how this is handled natively by EO.)

On 04/17/15 21:59, r-a-y wrote:

Are you talking about |example.com/events/event/POST-SLUG|?

This is handled by EO's default template. I do not think we should do anything for EO's default template.

By that I mean, we shouldn't force the BP interface on it. If we do want to do something, my thoughts are we should just widen the template and make it look less like a WP post.

Widening the template is something that we cannot do for all WP themes due to theme compatibility, but it's something we can do for CAC.

— Reply to this email directly or view it on GitHub https://github.com/cuny-academic-commons/bp-event-organiser/issues/31#issuecomment-94113446.

r-a-y commented 9 years ago

I think I've done enough to address this for the plugin.

For CAC, we can copy single.php from bp-default, paste in our theme directory and rename to single-event.php to do additional mods there.

r-a-y commented 9 years ago

Going to close this one.