search

cuny-academic-commons / bp-event-organiser

Allows Event Organiser plugin events to be assigned to BuddyPress groups and generates a group calendar page for each group
GNU General Public License v2.0
3 stars 1 forks source link

Upcoming Events archive #32

Closed christianwach closed 9 years ago

christianwach commented 9 years ago

I've posted a gist for an "upcoming events" archive, as per Stephen's code hints (which I can't find right now) - I reckon a list view would be a useful addition. I've posted it separately as it's code I use outside of a BP context that I wanted to offer up for review, plus there'll most likely need to be some kind of check for naming collisions before inclusion.

Thoughts?

christianwach commented 9 years ago

I should mention that this is implemented on IHC, though there are no events at present. The IHC site has a custom 'archive-event.php' template (amongst others) for showing this.

boonebgorges commented 9 years ago

Thanks, Christian. This is related to #25. I'm not sure whether having a separate rewrite endpoint for this is necessary within the context of bp-event-organiser (as you note), especially since we would want this to work within group/user contexts as well. But let's definitely look at what you've written here as we think more about #25

On 04/20/15 09:27, Christian Wach wrote:

I should mention that this is implemented on IHC http://islamichistorycommons.org/events/event/upcoming-events/, though there are no events at present. The IHC site has a custom 'archive-event.php' template (amongst others) for showing this.

— Reply to this email directly or view it on GitHub https://github.com/cuny-academic-commons/bp-event-organiser/issues/32#issuecomment-94450669.

christianwach commented 9 years ago

@boonebgorges Thanks - I'd overlooked that issue.

boonebgorges commented 9 years ago

As part of #25, I decided to go with the suggestion of calling this list "Upcoming" - it didn't seem obviously useful to me to have a list view of past events. I did implement it slightly differently from what you suggested here. See the commits attached to #25 for more details.