cuny-academic-commons / cac-featured-content

WordPress plugin for featuring BuddyPress or WordPress content in a widget
6 stars 1 forks source link

Please add «…» after a Blog excerpt. #1

Closed schwarzaufweiss closed 12 years ago

schwarzaufweiss commented 12 years ago

Really cool plugin. Thanks.

If it's e.g. a Blog excerpt what is automatically shown in the widget please add «…» at the end like we know it from normal WP Blog excerpts.

humanshell commented 12 years ago

I'm glad you like the plugin.

Are you talking about the "Read More..." link? You can change that to "Read More >>" or "Read More →" or "Read More »" in the widget admin.

schwarzaufweiss commented 12 years ago

Thanks for your reply.

No, not «Read more…» – I've already changed (localized) that. I'm talking about the end of the excerpt itself; the situation when «Custom Description» is left blank and automatically filled out by your script. It's what most WP themes are doing.

humanshell commented 12 years ago

Could you send me a link to a blog that has «...» around its excerpts? My blog (http://humanshell.net) which is hosted at wp.com and is running the twentytwelve theme does not add these characters to my excerpts on the home page. I've also previewed my site with a few other themes and none of them add these characters around the excerpts.

schwarzaufweiss commented 12 years ago

:-) Oh sorry Dominic. Not these "«»". Only the three or sometimes four points at the end. Please have a look:

https://www.info.ch/mitglieder/ - and you can see here how I know it from typical WP excerpts: https://www.info.ch/blog/

humanshell commented 12 years ago

OK, that makes much more sense. :-)

I will add ellipses "…" to the description text in the next release.

Thank you for your feedback.

boonebgorges commented 12 years ago

I think this was closed accidentally :)

@humanshell, BP has a handy function bp_create_excerpt() which would be ideal for this purpose.

humanshell commented 12 years ago

Yup, that's my bad - I accidentally clicked Comment & Close.

I will look into using bp_create_excerpt() in the next release to implement this functionality.

schwarzaufweiss commented 12 years ago

…and please have a look at the difference between https://www.info.ch/aktivitaet/ and https://www.info.ch/mitglieder/ Only cosmetics. But it's nice to have another perfect AND beautiful add-on for BuddyPress.

humanshell commented 12 years ago

@schwarzaufweiss are you still experiencing an issue with "…"? I've been looking through the plugin and it does use bp_create_excerpt() when displaying descriptions in the widget. I assume that if you are not seeing them, then you need to lower the value in the Crop Length input. It defaults to 250, so if the description that's being pulled for the selected content type is less than that number it will not create an excerpt and therefore will not display "…"

Let me know if that makes sense.

schwarzaufweiss commented 12 years ago

@humanshell, to lower the value was indeed the solution. Thanks. Now it's showing the ellipses for both widgets. Only thing is that they are in brackets […] after a space and not directly added after the excerpt.

humanshell commented 12 years ago

I'm glad it's working. That is the default for the BuddyPress bp_create_excerpt() function. As you can see in some of the activity updates in your original example link:

https://www.info.ch/mitglieder/

I'm a little wary to change this. This plugin is really meant to feature BuddyPress content, and I think the default ellipses " […] " shows that. Is this a big deal for you? Do you need to be able to change that output?

schwarzaufweiss commented 12 years ago

I would say there is no need to change that behavior; doesn't make sense to change a BP function within a plugin. In the beginning I was referring to the way WP is doing it. Really only something cosmetic. Important was to know how to show them.

humanshell commented 12 years ago

Great, can we close this issue?

schwarzaufweiss commented 12 years ago

Yes. :-)

humanshell commented 12 years ago

Thanks, let me know if you run across anything else you think could be improved or needs to be fixed.