search

cuny-academic-commons / cbox-theme

Default theme for Commons In A Box
GNU General Public License v2.0
20 stars 15 forks source link

Menu styling #198

Closed christianwach closed 10 years ago

christianwach commented 10 years ago

Fixes the positioning of menu items in the context of the absolutely-positioned scheme in #197. Also fixes z-index of mobile menu on small screen sizes

christianwach commented 10 years ago

Follow up PR as proposed in https://github.com/cuny-academic-commons/cbox-theme/issues/129#issuecomment-43750126

christianwach commented 10 years ago

47c8b7150b718fe726bf076e7198e3eb8f453ca5 fixes a knock-on problem I've found... while the menus and drop-downs now function as expected, they no longer appear over the slider on the homepage. This is because the flexslider list items have z-index: 50 while the menu dropdowns only have z-index: 10.

christianwach commented 10 years ago

As far as I can tell, this leaves one remaining issue, which seems to be that if I set a font colour on the Below Header menu, the colour "leaks through" to grandchild sub-menu items in the other two menus.

christianwach commented 10 years ago

The reason for the above is that there appears to be a naming confusion WRT the three menus and their child menus: the three top-level menus have classes top-menu, main-menu and sub-menu respectively. However, every sub-menu ul also has the class sub-menu which causes the value of body.theme-option .sub-menu ul li a span (which defines the lower menu item colour) to take priority over body.theme-option .top-menu ul li a span and body.theme-option .main-menu ul li a span which define the other menu item colours.

In essence there are two possible routes to fixing this: either make the declarations more specific to each menu or rename the <nav class"sub-menu"> to something else that does not clash with the sub-menus.

@BoweFrankema these declarations seem to be generated by ICE classes with which I'm not familiar. Could you suggest where to look?

r-a-y commented 10 years ago

Going to merge these fixes as without them, the menu overlaps over the content, which isn't so great!

Let's open a new issue to talk about the font color menu overrides.

Thanks @christianwach!