search

cuny-academic-commons / cbox-theme

Default theme for Commons In A Box
GNU General Public License v2.0
20 stars 15 forks source link

Default logo does not display in Chrome 36+ #212

Closed christianwach closed 10 years ago

christianwach commented 10 years ago

I'm not sure what's happened recently to cause this, but a clean install of CBOX no longer shows the default logo in Chrome.

It seems to be caused by a mixture of declarations that work against one another: the absolutely-positioned <h1> has no width, the anchor nested within it inherits this (again with no width) and therefore the logo <img> inside the anchor does not show because it too has no width or height as a result of the default img declaration:

max-width: 100%;
height: auto;

This PR removes the default max-width only for logo images. This may cause some installs to behave strangely if they have very wide logo images. However, at the moment, I can't think of another way to get Chrome to display the logo without doing this.

r-a-y commented 10 years ago

It appears the problem occurs on Chromium 36 and up. Chromium 35 and below doesn't exhibit this problem.

@christianwach, your PR works, however I'm wondering if making the CSS declaration more specific would be better. Perhaps:

.icext-header-logo img {max-width:none;}
christianwach commented 10 years ago

@r-a-y more specificity sounds good to me.

r-a-y commented 10 years ago

Cherry-picked the last commit - bc87792b37.

Closing. Thanks @christianwach!