search

cuny-academic-commons / cbox-theme

Default theme for Commons In A Box
GNU General Public License v2.0
20 stars 15 forks source link

Sidebar Overlay Issue #217

Closed vothsco closed 9 years ago

vothsco commented 10 years ago

CBOX member Tim reports that when positioning the menu under the header, and adding an overlay to the sidebar, the overlay slightly goes over the navigation section. It should be underneath. I have been able to reproduce and am attaching a screen shot to better explain. Here is a link to the forum topic: http://commonsinabox.org/groups/help-support/forum/topic/sidebar-problem/

tim

christianwach commented 10 years ago

@vothsco This issue was also raised in https://github.com/cuny-academic-commons/cbox-theme/issues/210 and goes back to https://github.com/cuny-academic-commons/cbox-theme/issues/161 if the layering issue is also considered.

The problem seems to be that the code that applies the z-index when there's a background overlay applies it too widely. The sidebar z-index ends up with a higher value than the container for the sub-menu. The only way that I can see of applying a different z-index to the sidebar is through the defaults as specified in the theme CSS files, but there may be unintended consequences on sites which have configurations that I haven't tried locally.

I've created a PR for review https://github.com/cuny-academic-commons/cbox-theme/pull/218

r-a-y commented 9 years ago

Christian's fix was merged in #218. Closing.