Closed amandafrench closed 9 years ago
Rock on!
I should probably be managing something or someone instead ...
Thanks Amanda for the bug report and pull request. I've merged in your fix for now.
@boonebgorges - It may be better to update our profile field templates to use the new profile field type rendering since it became available in BP 2.0: https://buddypress.trac.wordpress.org/browser/trunk/src/bp-templates/bp-legacy/buddypress/members/single/profile/edit.php?marks=37,38#L32 https://buddypress.trac.wordpress.org/browser/trunk/src/bp-templates/bp-legacy/buddypress/members/register.php?marks=156,157#L144
Are we okay with doing this?
The bleeding edge cbox theme already takes care of this since it doesn't override any of the profile templates. It falls through to the bundled legacy templates.
Right, but we're concerned with those currently using the current version of CBOX Theme for a maintenance release.
What would break if we did this? People overriding the templates would see no change at all, right? Seems safe enough to me.
On 06/02/15 12:53, r-a-y wrote:
Thanks Amanda for the bug report and pull request. I've merged in your fix for now.
@boonebgorges https://github.com/boonebgorges - It may be better to update our profile field templates to use the new profile field type rendering since it became available in BP 2.0: https://buddypress.trac.wordpress.org/browser/trunk/src/bp-templates/bp-legacy/buddypress/members/single/profile/edit.php?marks=37,38#L32 https://buddypress.trac.wordpress.org/browser/trunk/src/bp-templates/bp-legacy/buddypress/members/register.php?marks=156,157#L144
Are we okay with doing this?
— Reply to this email directly or view it on GitHub https://github.com/cuny-academic-commons/cbox-theme/pull/236#issuecomment-108013389.
What would break if we did this?
Those using BP 1.9. Otherwise, I don't think anything would break. I'll test some things locally before making a commit.
For Commons In A Box, we don't care about anyone using BP 1.9 :)
On 06/03/15 13:10, r-a-y wrote:
What would break if we did this?
Those using BP 1.9. Otherwise, I don't think anything would break. I'll test some things locally before making a commit.
— Reply to this email directly or view it on GitHub https://github.com/cuny-academic-commons/cbox-theme/pull/236#issuecomment-108526885.
Fixes a compatibility issue with Custom Profile Fields plugin whereby the CBOX theme doesn't generate input fields on the public registration form for custom profile fields of type URL (field_type_url).