search

cuny-academic-commons / cbox-theme

Default theme for Commons In A Box
GNU General Public License v2.0
20 stars 15 forks source link

removed conditional statements as per issue #213 #246

Closed twelch555 closed 7 years ago

twelch555 commented 7 years ago

While troubleshooting this issue I found the following forum threads in the Commons in a Box support group: http://commonsinabox.org/groups/help-support/forum/topic/adding-profile-edit/ http://commonsinabox.org/groups/help-support/forum/topic/missing-profile-groups/

which in turn led me to issue #213.

This issue still exists in the most recent (1.0.13) so I thought I would create a "bigger blip on the radar screen" with a PR.

Thanks to @HardeepAsrani for providing the solution.

boonebgorges commented 7 years ago

Thanks very much for the pull request!

The conditional was originally added in https://github.com/cuny-academic-commons/cbox-theme/commit/5997ce3d797bfdaa3ab466ab61d66a3ebb293f3c in response to #205. I'm unsure how or why the logic introduced in that changeset stopped working - it must have been an upstream BuddyPress change. In any case, simply removing the check would reintroduce the interface issue that was originally reported in #205. I think we can fix cbox_profile_has_multiple_tabs() instead.

boonebgorges commented 7 years ago

See c5c012f. Thanks again for the PR!