BuddyPress 3.0 compatibility

[r-a-y]

Update: This issue was originally created to cover activation template changes, but now encompasses all issues with BuddyPress 3.0.

• [x] Activation template changes (see below)
• [x] Removal of deprecated legacy forum calls (see commits 89c0142, 3ab4fd7, 86ad1a5)
• [x] Photo upload problems (see commit 2d92351, this isn't necessary for BP 3.2.0)

---

In BuddyPress 3.0, the activation template has changed.

Previously, simply loading a URL like /activate/12345 would activate the account with key 12345.

BP 3.0 no longer does this. For CBOX theme, we'll need to mirror the following changeset in order to auto-populate the activation key field: https://buddypress.trac.wordpress.org/changeset/11766/trunk/src/bp-templates/bp-legacy/buddypress/members/activate.php

[r-a-y]

@boonebgorges - I've added the activation template change to master branch.

One thing I thought of is do we have to worry about sites using < BP 3.0? If so, we'll have to change up the template to add some conditionals. I guess this applies more for those cloning bp-default.

[boonebgorges]

Once we bump the minimum BP requirement in CBOX, it should be updated at the same time as cbox-theme. So I don't think we need to account for older BP. Does that sound right?

[r-a-y]

I was thinking about those that clone and pull cbox-theme (or bp-default) without updating BuddyPress to v3.0 immediately.

In those instances, the activation page would throw a fatal error due to the use of a BP 3.0 function. Am I overthinking things?

[boonebgorges]

Ah, I see. Yeah, I think that's overthinking. Anyone doing weird stuff should know enough to test :)

[r-a-y]

Gotcha. Thanks for the sanity check!