search

cuny-academic-commons / commons-in-a-box

Commons In A Box - A suite of community and collaboration tools for WordPress, designed especially for academic communities
http://commonsinabox.org
72 stars 14 forks source link

My Profile > Edit Profile - extra links in subnav #299

Open bree-z opened 6 years ago

bree-z commented 6 years ago

The subnav includes three extra links that shouldn't be there.

myprofile_subnav
boonebgorges commented 6 years ago

It looks like someone has set up additional profile field groups at http://openlabdev.commonsinabox.org/wp-admin/network/users.php?page=bp-profile-setup. The theme does not support having more than one field group. Here are our options:

  1. Add to the documentation that all profile fields have to be in the Base group, and do nothing technically.
  2. Do something technically to prevent people from creating additional field groups.
  3. When someone creates more than one field group, show them all on a single page on Edit Profile. This would require a moderate amount of technical work, since BP currently handles them on separate pages. We'd also probably want design work, since we'd probably want a new level of subheading to indicate the groups.
  4. Make the necessary modifications to make the sublinks work, so that different field groups are handled on separate edit pages (as in BP). This would require some technical work, and also some design work to determine how the field group links (as shown in the screenshot) should work.
bree-z commented 6 years ago

Sorry, I have no idea how I closed this by accident. :-/

mkgold commented 6 years ago

We use "cancel friendship" on the Commons and I think that's fine

boonebgorges commented 6 years ago

@mkgold I have copied your comment to https://github.com/cuny-academic-commons/openlab-theme/issues/189#issuecomment-389595644, which I think is where you meant to leave it.

jennaspevack commented 6 years ago

I think 1. or 2. make sense here.

boonebgorges commented 6 years ago

Thanks, @jennaspevack. Let's go with 1 for now, as I'm unsure whether 2 will be technically possible without a lot of work.

boonebgorges commented 6 years ago

Looks like no additional development work is needed here for the Beta - it'll all be in documentation - so I'm moving this to a future milestone so we can perhaps come up with a better solution down the line.