search

cuny-academic-commons / commons-in-a-box

Commons In A Box - A suite of community and collaboration tools for WordPress, designed especially for academic communities
http://commonsinabox.org
72 stars 14 forks source link

Course Settings > Additional Faculty Dropdown doesn't show all faculty member in the OpenLab directory #364

Open arto-a opened 3 years ago

arto-a commented 3 years ago

The dropdown for adding additional faculty in the Course Settings page does not display users who are not already members of the course.

URL: https://openlabdev.commonsinabox.org/groups/hegel-and-marx-logical-studies/admin/edit-details/

Screenshot is attached. Screenshot from 2021-07-22 15-10-09

bree-z commented 3 years ago

Hi Boone,

In case it's helpful, I just wanted to add that the dropdown for group invitations shows all users that match whatever is typed in the box.

Also, I was testing in this course: https://openlabdev.commonsinabox.org/groups/summer-2021-course-shared-clone-2/, logged in as breefaculty, and the only member of the course.

When I typed in 'test', no member names appeared. But, after the 'testfaculty' user joined the group, 'testfaculty' appeared when I typed in 'test'.

Thanks!

boonebgorges commented 3 years ago

What is the desired behavior?

bree-z commented 3 years ago

On the OpenLab, all faculty who are members of the OpenLab (not just the course) whose names match, appear in the dropdown, e.g.:

AdditionalFacultyDropdownOL
boonebgorges commented 3 years ago

Thanks. This feature in CBOX-OL was based on the Group Contact feature from the OpenLab, which is related to but not identical to Additional Faculty. OL's Group Contact behaves the same way: namely, this autocomplete field matches only members of the group. For prior discussion, see http://redmine.citytech.cuny.edu/issues/2033, particularly the comments through 7.

It's not really feasible to do a match of all "faculty" on CBOX-OL, because we can't be sure that the category "faculty" will exist, or if it does, that it will have similar semantics to City Tech. Moreover, the Group Contact feature across all group types is unified under the hood, meaning that a change in the behavior here affects all other group types as well.

So there are a few options:

  1. Do nothing. This means that it will be possible to add all and only group members as Contacts via this mechanism.
  2. Change the behavior so that the autocomplete matches any site member. This will apply to all group types.
boonebgorges commented 3 years ago

cc @bree-z ^

bree-z commented 3 years ago

Thanks Boone. Let's do nothing for now, and we can revisit to see if we want to make a change at a later date.