search

cuny-academic-commons / commons-in-a-box

Commons In A Box - A suite of community and collaboration tools for WordPress, designed especially for academic communities
http://commonsinabox.org
72 stars 14 forks source link

Template Picker should save state if you return to Site step using site creation navigation #448

Closed boonebgorges closed 1 year ago

boonebgorges commented 1 year ago

a. Choose to create an associated site b. Select a template for the site c. Click the Previous Step d. Go back to Associated Site template e. THEN the state of the previously selected template is not saved (or shown).

I'm not 100% sure when the site template cloning process actually takes place. It's possible that it happens immediately after you click 'Next' from the Site tab. If so, then returning to the Site tab and changing the Template option would do nothing, in which case it feels misleading to show the previous state and allow it to be changed. In that case, perhaps we grey out the entire thing.

boonebgorges commented 1 year ago

Reviewing this, here's what I've found:

  1. On the 'Site' step during group creation, the group site is created immediately after clicking 'Next Step'. This means that the template is also applied at the very same time. This action is not reversible.
  2. However, I also found that the 'Site Template' option doesn't actually appear when you click on Previous Step. This dates from dc93a1ff6462ee2fd9716e26a90861052ee13736 #423.

As such, I don't think that any further action is required here. The problem should have been resolved in #423. It could be that the reporter was running an out-of-date version of CBOX. (Given that it was BMCC that reported it, and given that they may still be using their standalone version of cboxol-site-template-picker, I'm guessing this is the case.)