search

cuny-academic-commons / commons-in-a-box

Commons In A Box - A suite of community and collaboration tools for WordPress, designed especially for academic communities
http://commonsinabox.org
72 stars 14 forks source link

Template Chooser > Site templates don't appear during course and creation #450

Closed bree-z closed 11 months ago

bree-z commented 11 months ago

Hi Boone,

The template chooser doesn't appear during course or portfolio creation. It does appear during project and club creation.

In the template chooser dashboard interface I see that there are four templates for courses, in three different categories. For portfolios there are two templates in two categories.

If I go to course settings of an existing course, unlink it from the site, and then create a new site I see the template chooser with all the available templates.

If I do the same for portfolios, I don't see the template chooser.

Thanks!

boonebgorges commented 11 months ago

I think this is linked to changes in #447, which changed the logic determining when the panel should show.

I've made a change in cuny-academic-commons/cbox-openlab-core@5f45a61b4f5d2b6eb3e07b04085f3d1781bcc55a that seems to fix the issue in my testing.

bree-z commented 11 months ago

Thanks Boone! The template chooser panel now appears during course and portfolio creation. It's also still there during project and club creation.

However, for projects and clubs that don't include an associated site by default, the panel appears before before I click 'Set up a Site'. Previously it would appear after clicking 'Set up a Site'. The same happens for groups that don't have an associated site when I go to Group Settings > Site.

boonebgorges commented 11 months ago

Thanks for pointing this out. It should now be fixed.

bree-z commented 11 months ago

Thanks Boone! This looks good.

bree-z commented 11 months ago

Hi Boone,

I'm not sure if I missed this earlier or if it's something new, but I'm not seeing the template chooser panel during portfolio creation, or in settings.

There were two templates associated with portfolios when I noticed this. I added a third, but still didn't see the panel.

Thanks!

boonebgorges commented 11 months ago

There was a problem in my last change that caused the picker not to appear properly for group types where associated sites are required. This should now be fixed.

bree-z commented 11 months ago

This looks good, thanks!

I see it on all group types at creation and in settings, if I unlink the site.