cuny-academic-commons / commons-in-a-box

Commons In A Box - A suite of community and collaboration tools for WordPress, designed especially for academic communities
http://commonsinabox.org
72 stars 14 forks source link

After accepting invitation from group profile, link to group is incorrect #456

Closed bree-z closed 7 months ago

bree-z commented 10 months ago

I've confirmed the bug reported in https://cboxopenlab.org/groups/help-forum/forum/topic/bug-incorrect-url-generated-when-accepting-group-invite/

Logged in as teststudent, I navigated to the profile of https://openlabdev.commonsinabox.org/groups/13er-club/ and clicked 'Accept Invitation'.

I saw the message that the invitation was accepted: "Group invite accepted. Visit 13er Club." The link was: https://openlabdev.commonsinabox.org/%22https://openlabdev.commonsinabox.org/groups/13er-club//%22

I don't think I've ever accepted an invitation this way, so I'm not sure I've ever seen this message before now! But I don't think the link to the group makes much sense, since you're already there. Perhaps we just remove the second sentence?

Screenshot 2023-08-18 at 5 16 11 PM
boonebgorges commented 10 months ago

This is due to an issue with the way that quotes are being escaped. It should be fixed in cedfc2e.

bree-z commented 7 months ago

This looks good, thanks!