New sites created with incorrect menu items

[bree-z]

Hi Boone,

This is probably for a later release, but I was able to reproduce one of the menu issues I noticed on my own test site:

• I created a new template, Dec 23 New Template.
• I changed the theme from Twenty Twenty Three to Twenty Seventeen.
• I created a new course site using the new template.
• Instead of having '[Course Home]' in the menu, site has a menu item called 'Group Home' which links to: https://openlabdev.commonsinabox.org/site-template-dec-23-new-template-1702894203/group-profile. The 'Home' link also links to the template: https://openlabdev.commonsinabox.org/site-template-dec-23-new-template-1702894203/

At first I thought it was just an issue with newly created templates, but I got the same issue when I created new group sites using a few existing templates, e.g.:

• I created this club using the existing template SGA Clubs.
• https://openlabdev.commonsinabox.org/more-project-template-testing-3/ creating using the Department Site Template.

Thanks!

[boonebgorges]

It's possible that this is being caused by a small change I'd put in place while we were working on #459. As we decided to "do nothing" on that ticket, I've reverted that small change. Perhaps you could try again to see if this reverted commit fixes the behavior you've described here. If not, we'll have to handle in a future release.

[bree-z]

Thanks Boone. I still see the same behavior.

[boonebgorges]

Sounds good. We'll review this in the future.