Portfolio creation issue: site is not created

bree-z commented 7 years ago

Following Scott's report in #62 I retested and found the following issue:

I deleted the existing portfolio profile, but not site, for the Test Student account, and tried to create another portfolio
The default site URL was openlabdev.commonsinabox.org/eportfolio
I didn't change this, and after clicking "Continue," saw an error message that the URL for the default site was already taken.
I changed the site URL to /test-student-portfolio
On the next page (privacy settings) I only saw one set of privacy settings, for the profile
The profile was created successfully, but not the site
I went to profile > Settings > Create new site, and tried the same URL as above, /test-student-portfolio
The site was created, and the correct link displayed on the profile.
I repeated this with a staff account that had no portfolio and the exact same thing happened

On the OpenLab, the site URL default is "first initial + last name + n-dash + portfolio", e.g. "bzuckerman-portfolio". Can we do the same on CBOX-OL?

CBOX:

OL:

boonebgorges commented 7 years ago

Thanks for the detailed report, @bree-z.

On the OpenLab, the site URL default is "first initial + last name + n-dash + portfolio", e.g. "bzuckerman-portfolio". Can we do the same on CBOX-OL?

Not exactly. We aren't guaranteed the existence of first or last name like we are on the OpenLab. Also, "first initial" isn't a concept that makes sense in all languages. Instead, I've opted for: [display_name]-portfolio.

There were a couple of validation problems and load-order issues that were preventing portfolio site names from being detected properly. I think I've addressed all of them in the commits referenced on this ticket. Could you give it another round of testing, with #62 in mind as well? Thanks!

bree-z commented 7 years ago

Thanks, Boone! The site creation issue is fixed.

The only issues is perhaps what @vothsco was reporting in #62 . For other group types, profile and site deletion are independent of one another, but when I deleted a portfolio in Profile > Settings, the site was also automatically deleted (e.g. http://openlabdev.commonsinabox.org/testfaculty-portfolio/). I think we want portfolio deletion to match other groups.

Thanks!

bree-z commented 7 years ago

I'm going to close this because portfolio creation looks good. I'll add the deletion issue to #62 .

cuny-academic-commons / openlab-theme

Portfolio creation issue: site is not created #64