search

cuny-academic-commons / social-paper

Work in progress. Bleeding-edge alpha. Do not use on production sites!
9 stars 6 forks source link

Change Follow button to Follow Papers Button #90

Open profstein opened 8 years ago

profstein commented 8 years ago

Also change Unfollow to Unfollow Paper

Due to the placement of the button in line with the author this change helps to make sure people don't think they are following the author instead of the paper.

image

boonebgorges commented 8 years ago

Making the change it this point would affect much of the documentation that's already been prepared, so we're going to postpone this change.

profstein commented 8 years ago

Ok, we do Think that there is potential for confusion so if you could apply in an early dot release that would be nice.

On Nov 25, 2015, at 4:45 PM, Boone Gorges notifications@github.com<mailto:notifications@github.com> wrote:

Making the change it this point would affect much of the documentation that's already been prepared, so we're going to postpone this change.

Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_cuny-2Dacademic-2Dcommons_social-2Dpaper_issues_90-23issuecomment-2D159738166&d=AwMCaQ&c=nI61yajbN8Wpmagq-MfhuPVQx6fheJzyqdJgIHizQCg&r=TYqAlEczAGrDMU8DN5yGUjYNQBifq4FtNemzKj8b9hk&m=31fHwuF_HCO0_a82ENJpUZ4ieMYEJoHjJspfQOuiFhk&s=x-zkPmQ3vB-ks6J6hqdnGrTAnf8h_cnh9wi4YrTzAn8&e=.

boonebgorges commented 8 years ago

Just to clarify - who is "we"? Is it you and @samradd ?

It's technically easy for me to make the change, but changes like this have to be reflected across our docs, which is time-consuming. This is why we had a deadline for functional and design changes :) But yes, let's try to coordinate with the team on a release that will require docs changes - ideally, they'll be grouped together, to minimize the effort required of the documentation team.

profstein commented 8 years ago

Yes @samradd is the other part of we. And I'm on board with collecting these changes so they can be documented properly and more efficiently.

On Nov 25, 2015, at 5:20 PM, Boone Gorges notifications@github.com<mailto:notifications@github.com> wrote:

Just to clarify - who is "we"? Is it you and @samraddhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_samradd&d=AwMCaQ&c=nI61yajbN8Wpmagq-MfhuPVQx6fheJzyqdJgIHizQCg&r=TYqAlEczAGrDMU8DN5yGUjYNQBifq4FtNemzKj8b9hk&m=c-v61l8Iql9MmJQEnX4yNnOvSZwoNdYvoKq3JBfqZSE&s=nQ2YavAEdd74Gg0MVvxqt6THn2_cJyIHdzxYddJ5Al0&e= ?

It's technically easy for me to make the change, but changes like this have to be reflected across our docs, which is time-consuming. This is why we had a deadline for functional and design changes :) But yes, let's try to coordinate with the team on a release that will require docs changes - ideally, they'll be grouped together, to minimize the effort required of the documentation team.

Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_cuny-2Dacademic-2Dcommons_social-2Dpaper_issues_90-23issuecomment-2D159744499&d=AwMCaQ&c=nI61yajbN8Wpmagq-MfhuPVQx6fheJzyqdJgIHizQCg&r=TYqAlEczAGrDMU8DN5yGUjYNQBifq4FtNemzKj8b9hk&m=c-v61l8Iql9MmJQEnX4yNnOvSZwoNdYvoKq3JBfqZSE&s=7PT6EXK6IFw6qmczN-Qbn-1o4eJWWhNYR5Gd1nRpPpk&e=.