cunybpl / aiodal

async data access layer and related tools for sqlalchemy core
0 stars 0 forks source link

WhereFilter AliasTable `KeyError` #13

Closed bsnacks000 closed 11 months ago

bsnacks000 commented 11 months ago

One thing we overlooked was in filters module, the current filters do not work with aliased table since the new Transaction API has seperate explicit method calls which return a Table or TableAlias.

So this leads to tests failing downstream in bemadb where we set the aliased table in one place in the builder and then when we add filters later via dynamic where clause it is calling into the wrong method.

I will refactor the filters module somewhat in order to create a consistent check in the transaction manager for the right table.